Using related.attributes[ key ] instead of related.get( key ) in toJSON#379
Open
itoldya wants to merge 1 commit intoPaulUithol:masterfrom
itoldya:master
Open
Using related.attributes[ key ] instead of related.get( key ) in toJSON#379itoldya wants to merge 1 commit intoPaulUithol:masterfrom itoldya:master
itoldya wants to merge 1 commit intoPaulUithol:masterfrom
itoldya:master
Conversation
…instead of using 'get' method
Owner
|
Is anybody else in favor (or opposing to) of making this change? The call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Standard behavior of Backbone.Model.toJSON method is just clone values from attributes dict. In my case i using some conversion in get and set methods, for example: