Use ConfigMaps for redis.conf and aclfile#103
Conversation
Contributor
Author
|
Closed
shyimo
reviewed
Jun 14, 2021
| @@ -0,0 +1,2051 @@ | |||
| # Redis configuration file example. | |||
Contributor
There was a problem hiding this comment.
since we are now using configmap, can you please mark the changes that was made in the config file in order to allow the usage of the ACL ?
Contributor
Author
There was a problem hiding this comment.
You can see the differences between the current config and the changes introduces in this PR here:
https://gist.github.com/voltbit/e0dde5992f39d55246665e0390f76937/revisions
ignore the 'slaveof' and 'requirepass' differences
the important changes are:
aclfile "/usr/local/etc/redis/acl/users.acl" this is the only ACL setting
save "" this disables RDB dumps
reference files:
https://raw.githubusercontent.com/antirez/redis/6.2.0/redis.conf
https://raw.githubusercontent.com/antirez/redis/5.0.0/redis.conf
- Updated the redis.conf file to version 6.2 - Moved the redis.conf outside of the code - Added ACL example config - Created Helm ConfigMaps templates for redis.conf and ACL configuration - Disabled rdb dump persistence
shyimo
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
differences between the current config and the changes introduced
https://gist.github.com/voltbit/e0dde5992f39d55246665e0390f76937/revisions
reference files:
https://raw.githubusercontent.com/antirez/redis/6.2.0/redis.conf
https://raw.githubusercontent.com/antirez/redis/5.0.0/redis.conf
Part of #100
closes #75