Merged
Conversation
glassnotes
reviewed
Jul 14, 2022
Contributor
glassnotes
left a comment
glassnotes
left a comment
There was a problem hiding this comment.
Everything is looking good here! Just minor comments.
antalszava
suggested changes
Jul 18, 2022
Contributor
antalszava
left a comment
antalszava
left a comment
There was a problem hiding this comment.
Looking good overall @mudit2812! 👍 Just a couple of comments.
Co-authored-by: antalszava <antalszava@gmail.com>
antalszava
approved these changes
Jul 20, 2022
Contributor
antalszava
left a comment
antalszava
left a comment
There was a problem hiding this comment.
Looks good! 👏 Great catch again with Counts, thanks for pointing that out!
glassnotes
approved these changes
Jul 20, 2022
Contributor
glassnotes
left a comment
glassnotes
left a comment
There was a problem hiding this comment.
Thanks @mudit2812, looks great!
Co-authored-by: Olivia Di Matteo <2068515+glassnotes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
There are very few simulators available today that offer qudit simulation. One notable example is Google's Cirq, which includes support for qudit operations. However, the simulator is far from complete, and a key drawback is the lack of operations available, which creates a need for users to define operations themselves. Popular libraries such as Qiskit and QuTiP also include some qudit manipulation capabilities, but with few use cases. Beyond these libraries, qudit simulation solutions are quite limited. Moreover, qudit simulation is a feature that is already in demand, as seen in this issue on the PennyLane repository.
This PR updates the
QutritDeviceabstract base class introduced in PR #2781 such that execution now supports measurement as well.Description of the Change:
QutritDevice. Users can now execute a quantum tape including both operations and measurements. Currently supported measurements includeqml.state()andqml.probs().Benefits:
Possible Drawbacks:
Related GitHub Issues:
#2190