Batched csr in ParametrizedEvolution with jax version bump#4126
Merged
Batched csr in ParametrizedEvolution with jax version bump#4126
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4126 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 340 340
Lines 30523 30523
=======================================
Hits 30456 30456
Misses 67 67
|
dwierichs
reviewed
May 18, 2023
Contributor
dwierichs
left a comment
There was a problem hiding this comment.
Nice change, I like how minimal it is while unlocking quite a bit of performance in the long run :)
Just wondering whether we
- may break anything with the new
doc/requirementssettings, and - should add a test that makes use of a particular
BCSRfeature thatCSRwould fail.
For the second, I think it is not really necessary, but it might be nice.
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
Contributor
Author
Yes good point! Testing now differentiating the unitary matrix with jit, no jit, dense, and sparse :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #4079 which hot-fixes #4078, we can now fix it for good with batched CSR. This update is necessary anyway since "vanilla" CSR format will be deprecated soon (see jax-ml/jax#15844 (comment))