Support broadcasting in simulate and preprocess#4244
Merged
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4244 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 352 352
Lines 31983 32012 +29
=======================================
+ Hits 31916 31945 +29
Misses 67 67
|
josh146
reviewed
Jun 13, 2023
mudit2812
approved these changes
Jun 15, 2023
Contributor
mudit2812
left a comment
mudit2812
left a comment
There was a problem hiding this comment.
Looks good to me! I left a non-blocking suggestion.
timmysilv
approved these changes
Jun 15, 2023
Contributor
Author
|
[sc-40107] |
timmysilv
added
the
merge-ready ✔️
frederikwilde
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Support broadcasting in state measurements * docs for is_state_batched * Support broadcasting in sample measurements * Support broadcastingin simulate and preprocess --------- Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged after #4238
Context:
Part of the development of the new qubit device in PennyLane.
Description of the Change:
Support broadcasting in the
simulatefunction and in the preprocessing functions indevices/qubit/preprocess.py. Built-in PennyLane broadcasting will now used when executing qscripts in the new device, unless the execution config specifiesgradient_method="adjoint", in which caseqml.transforms.broadcast_expandwill still be used to split executions.