Add new string representation to FermiWord#4255
Merged
Conversation
soranjh
changed the title
FermiWordFermiWord
Codecov Report
@@ Coverage Diff @@
## master #4255 +/- ##
========================================
Coverage 99.78% 99.78%
========================================
Files 352 352
Lines 31754 31883 +129
========================================
+ Hits 31686 31816 +130
+ Misses 68 67 -1
|
Jaybsoni
reviewed
Jun 15, 2023
Jaybsoni
reviewed
Jun 15, 2023
Jaybsoni
reviewed
Jun 15, 2023
Contributor
Jaybsoni
left a comment
Jaybsoni
left a comment
There was a problem hiding this comment.
Overall looks good, added some suggestions. Also for some reason I can't find FermiWord when I search for it on the docs page? Once these concerns are addressed I am happy to approve 👍🏼
Jaybsoni
reviewed
Jun 15, 2023
Contributor
Author
The documentation is checked/updated in a dedicated PR. |
lillian542
reviewed
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Change the string representation of
FermiWordfrom'0+ 1-'to'a⁺(0) a(1)'.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: