Add functions to return excited basis states#4417
Merged
soranjh merged 10 commits intoinitial_state_ucisdfrom Aug 2, 2023
Merged
Add functions to return excited basis states#4417soranjh merged 10 commits intoinitial_state_ucisdfrom
soranjh merged 10 commits intoinitial_state_ucisdfrom
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #4417 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 351 351
Lines 32695 32728 +33
=======================================
+ Hits 32617 32650 +33
Misses 78 78
|
* fix has_decomposition for ControlledQubitUnitary * changelog * add comment; add test when super returns False
soranjh
changed the title
* `wire_order` kwarg for `Tensor.sparse_matrix()` * update changelog * swap kwarg order Co-authored-by: Matthew Silverman <matthews@xanadu.ai> * adapt docstring to the kwarg order swap * add comment about using over --------- Co-authored-by: Matthew Silverman <matthews@xanadu.ai>
Chiffafox
requested changes
Aug 2, 2023
Contributor
Chiffafox
left a comment
Chiffafox
left a comment
There was a problem hiding this comment.
This looks great! Have a few comments, mostly minor items and questions for discussion.
…measurements (#4426) * fix split non commuting * changelog * pylint
…neAI/pennylane into initial_state_excitation
…4388) * default shots on new device interface * make fewer changes and clean stuff up later * fix tests, lint, and sphinx * Update doc/releases/changelog-dev.md * Update tests/interfaces/test_set_shots.py Co-authored-by: Matthew Silverman <matthews@xanadu.ai> * Update tests/devices/experimental/test_default_qubit_2.py * make set_shots error with new device, shots type hinting * Update doc/releases/changelog-dev.md Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com> * Update pennylane/interfaces/set_shots.py Co-authored-by: Matthew Silverman <matthews@xanadu.ai> * Apply suggestions from code review * Update tests/devices/experimental/test_default_qubit_2.py * merge problem * black * Update doc/releases/changelog-dev.md * Update pennylane/qnode.py Co-authored-by: Edward Jiang <34989448+eddddddy@users.noreply.github.com> --------- Co-authored-by: Matthew Silverman <matthews@xanadu.ai> Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Edward Jiang <34989448+eddddddy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Functions are added to compute excited states, as occupation-number vectors, from a Hartree-Fock reference state. These functions are need to convert PySCF wave functions to a state vector.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: