Merged
Conversation
- Trigger code-quality workflow on pull_request to main - Split quality gates into explicit jobs: - lint (format + analyzer checks) - build (warn-as-error) - Add approve-pr job using actions/github-script with secrets.GC_PAT - Approve only when lint and build both succeed - Block approval when unresolved PR review threads/comments exist - Add explicit approval message with verified checks: - Linting passed - Build passed - All review comments resolved - Include structured JSON payload in review comment for pipeline parsing - Add bot guard conditions to reduce self-trigger/loop risk Refs: #81
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the GitHub Automated Reviewer (GC) capability from Issue #81. It restructures the code-quality workflow to separate lint and build into distinct jobs, adds analyzer warnings checking to the lint job, upgrades builds to use /warnaserror, and introduces an approve-pr job that auto-approves PRs when all quality gates pass and all review threads are resolved.
Changes:
- Split the single lint+build job into separate
lintandbuildjobs (withbuilddepending onlint), adding analyzer warning checks and explicit/warnaserrorflags - Added
approve-prjob that usesactions/github-scriptwith a dedicated PAT (GC_PAT) to auto-approve PRs, including GraphQL-based unresolved review thread detection and structured JSON output - Added bot guard conditions and branch filtering (
main) to prevent self-triggering loops
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #81