Add PaginatedPublisher to replace ScrollPublisher to support both scroll and search after api for search queries#3724
Open
jk-leong wants to merge 1 commit intoPhilippus:series/9.xfrom
Conversation
Author
|
Hi @Philippus ! Will need your help to review this PR to check if there's anything I have missed out 😄 |
jk-leong
force-pushed
the
add-publisher-for-search-after-queries
branch
3 times, most recently
from
b885b88 to
28f5f29
Compare
Author
|
Fixed the lint issues @Philippus |
…oll and search after queries
jk-leong
force-pushed
the
add-publisher-for-search-after-queries
branch
from
28f5f29 to
62e441d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue:
Following up from issue to add search after functionality for publisher:
#2666
Reason for change:
Elasticsearch now recommends the use of search after API over scroll api for deep pagination.
https://www.elastic.co/docs/reference/elasticsearch/rest-apis/paginate-search-results#scroll-search-results
Changes made:
ScrollPublisherwithPaginatedPublisherthat supports amodeparam that if passed in withSearchAfterobject will use thesearch_afterapi