easyinstall: refactor script to be invoked as root#1626
Draft
easyinstall: refactor script to be invoked as root#1626
Conversation
3e14c8e to
d280721
Compare
Rather than running sudo inline for every command, require that the script is invoked as a root user This allows the script to run cleanly in chroot, while eliminating the need for sudo caching logic
d280721 to
e9c3210
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than running sudo inline for every command, require that the script is invoked as a root user
This allows the script to run cleanly in chroot, while eliminating the need for sudo caching logic