scsidump: Allow to start at a specific offset#1633
Merged
rdmark merged 1 commit intoPiSCSI:developfrom Jan 6, 2026
Merged
Conversation
rdmark
requested changes
Jan 6, 2026
Member
rdmark
left a comment
rdmark
left a comment
There was a problem hiding this comment.
thank you for your contribution! the logic looks good. I have left a few stylistic / nitpick comments, so please take a look.
I'm using `scsidump` to dump old SCSI drives and from time to time, I run into errors. With this patch, I can resume a transfer (and will only lose 64 KB.)
jbglaw
force-pushed
the
jbglaw/allow-to-restart-scsidump
branch
from
08467a9 to
78f50cc
Compare
Author
|
Pushed a new version. All formatting changes are dropped, the only thing that remains to be correctly fixed IMHO is the man page. |
rdmark
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using
scsidumpto dump old SCSI drives and from time to time, I run into errors. With this patch, I can resume a transfer (and will only lose 64 KB.)