Skip to content

Suppress native installer warning when cc is installed by npm#483

Merged
bl-ue merged 5 commits intoPiebald-AI:mainfrom
brrock:disable-switch-to-native-warning
Feb 7, 2026
Merged

Suppress native installer warning when cc is installed by npm#483
bl-ue merged 5 commits intoPiebald-AI:mainfrom
brrock:disable-switch-to-native-warning

Conversation

@brrock
Copy link
Copy Markdown
Contributor

@brrock brrock commented Feb 7, 2026

Idk could be useful, very simple patch

Summary by CodeRabbit

  • New Features

    • Added a UI toggle and corresponding config option to suppress the native installer warning at startup (defaults to off).
  • Documentation

    • Updated README and changelog with usage details and added entries in the table of contents documenting the new toggle and config option.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 7, 2026

📝 Walkthrough

Walkthrough

Adds a configurable boolean to suppress a native installer startup warning, a UI toggle, a patch writer that removes the warning text, default settings and types updates, and README/CHANGELOG documentation; wires the patch into the patch system and gating logic.

Changes

Cohort / File(s) Summary
Configuration & Types
src/defaultSettings.ts, src/types.ts
Add suppressNativeInstallerWarning: boolean to default misc settings (default false) and to MiscConfig.
Patch Implementation
src/patches/suppressNativeInstallerWarning.ts, src/patches/index.ts
New writer `writeSuppressNativeInstallerWarning(file: string): string
User Interface
src/ui/components/MiscView.tsx
Add toggle entry to MiscView / defaultMisc to control settings.misc.suppressNativeInstallerWarning.
Documentation / Changelog
README.md, CHANGELOG.md
Add README TOC and feature description (appears duplicated) and one-line Unreleased entry in CHANGELOG documenting the patch.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant UI as MiscView (UI)
  participant Config as Settings
  participant PatchRunner as Patch System
  participant Writer as writeSuppressNativeInstallerWarning
  participant FS as Target File

  User->>UI: toggle "Suppress native installer warning"
  UI->>Config: update settings.misc.suppressNativeInstallerWarning
  PatchRunner->>Config: read settings
  alt setting enabled
    PatchRunner->>Writer: invoke writeSuppressNativeInstallerWarning(file)
    Writer->>FS: remove warning via regex, return modified content
    Writer->>PatchRunner: showDiff + return patched content
    PatchRunner->>FS: write patched content
  else setting disabled
    PatchRunner->>PatchRunner: skip patch
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • bl-ue

Poem

🐇 I hopped through code where warnings sing,
Snipped a noisy line with a careful spring.
A toggle here, a regex kiss,
Quiet startup—simple bliss! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a patch to suppress the native installer warning when using the npm-installed version of the tool.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@README.md`:
- Line 120: The table-of-contents entry "[Suppress native installer warning]" is
not indented and thus renders outside the "Features" list; update the README by
adding the same two-space indentation used by the other feature entries so that
the line starting with "[Suppress native installer warning]" is nested under the
"Features" section (match spacing of entries on lines 107–119).

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@brrock brrock changed the title Suppress native installer warning Suppress native installer warning when cc is installed by npm Feb 7, 2026
@bl-ue bl-ue merged commit 8a77872 into Piebald-AI:main Feb 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants