Skip to content

Fix tool call patching typo#542

Merged
bl-ue merged 1 commit intomainfrom
fix-toolset-patch-typo
Feb 23, 2026
Merged

Fix tool call patching typo#542
bl-ue merged 1 commit intomainfrom
fix-toolset-patch-typo

Conversation

@bl-ue
Copy link
Copy Markdown
Member

@bl-ue bl-ue commented Feb 23, 2026

Closes #534

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue with the toolset value displayed in the shortcuts display.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 23, 2026

📝 Walkthrough

Walkthrough

A typo fix replacing an incorrect state.toolset reference with currentToolset in the tool shortcuts display patch, accompanied by a changelog entry documenting the change.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md
Added changelog entry for tool call patching typo fix (#542).
Tool Patching
src/patches/toolsets.ts
Corrected shortcuts display to reference currentToolset instead of state.toolset.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A typo fixed with care so bright,
From state to current, now it's right!
The shortcuts dance with proper grace,
While bunnies cheer throughout this place! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix tool call patching typo' directly describes the main change: correcting a typo in the toolset patching logic where 'state.toolset' was replaced with 'currentToolset'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-toolset-patch-typo

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/patches/toolsets.ts (1)

627-631: Pre-existing: copy-paste error in the error message.

The console.error on line 629 still says 'patch: toolsets: appendToolsetToModeDisplay: …' instead of appendToolsetToShortcutsDisplay. Not introduced by this PR, but worth a one-line fix while the function is being touched.

🛠️ Proposed fix
-      'patch: toolsets: appendToolsetToModeDisplay: failed to modify mode display'
+      'patch: toolsets: appendToolsetToShortcutsDisplay: failed to modify shortcuts display'
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/patches/toolsets.ts` around lines 627 - 631, The error message string is
a copy-paste leftover referring to appendToolsetToModeDisplay; update the
console.error call in the appendToolsetToShortcutsDisplay flow so it logs
'patch: toolsets: appendToolsetToShortcutsDisplay: failed to modify shortcuts
display' (or equivalent clear message) when newFile === oldFile, keeping the
early return behavior using the same variables newFile/oldFile.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/patches/toolsets.ts`:
- Around line 627-631: The error message string is a copy-paste leftover
referring to appendToolsetToModeDisplay; update the console.error call in the
appendToolsetToShortcutsDisplay flow so it logs 'patch: toolsets:
appendToolsetToShortcutsDisplay: failed to modify shortcuts display' (or
equivalent clear message) when newFile === oldFile, keeping the early return
behavior using the same variables newFile/oldFile.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e425b0f and 587374b.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/patches/toolsets.ts

@bl-ue bl-ue merged commit 1db1be4 into main Feb 23, 2026
2 checks passed
@bl-ue bl-ue deleted the fix-toolset-patch-typo branch February 23, 2026 16:35
ljepson pushed a commit to ljepson/tweakcc that referenced this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cc 2.1.50 undefined is not an object (evaluating 'R.blue')

1 participant