[History] Match text for layer visibility toggle for checkbox and dialog#2104
Draft
pedropaulosuzuki wants to merge 4 commits intoPintaProject:masterfrom
Draft
[History] Match text for layer visibility toggle for checkbox and dialog#2104pedropaulosuzuki wants to merge 4 commits intoPintaProject:masterfrom
pedropaulosuzuki wants to merge 4 commits intoPintaProject:masterfrom
Conversation
Toggling the layer visibility with the dialog and the checkbox created different history strings.
Member
|
I would vote for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggling the layer visibility with the dialog and the checkbox created different history strings. Not sure which of those is the best string to use, so making this a draft.
We should also refactor this to make this be defined only once, to avoid duplication and future mismatches. I also need to the patch the icon before merging.
Continuation of #2098 (which I only noticed today)