[Shape Tool] Adds overridable BuildToolSpecificToolbar method#2107
Open
pedropaulosuzuki wants to merge 4 commits intoPintaProject:masterfrom
Open
[Shape Tool] Adds overridable BuildToolSpecificToolbar method#2107pedropaulosuzuki wants to merge 4 commits intoPintaProject:masterfrom
pedropaulosuzuki wants to merge 4 commits intoPintaProject:masterfrom
Conversation
The idea is to allow shape tools to include toolbar items before the stroke controls, which can disappear and would behave better when at the end of the toolbar.
This uses the BuildToolSpecificToolbar override, instead of overriding the base HandleBuildToolBar method.
…gets, instead of after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to allow shape tools to include toolbar items before the stroke controls, which can disappear and would behave better when at the end of the toolbar. One example is the Rounded Rectangle tool, that now has the Radius property right at the start, but just after the Shape Type dropdown.
I thought about only making the Stroke/Dash settings separate, but that would mean all implementations would have to call it anyway, so an optional overridable method seemed like a better choice.
Also fixes the Separator in the Freeform Shape Tool.
Closes #2012.