Refactor the toolbox widget to separate it from the ToolManager#2113
Merged
cameronwhite merged 1 commit intomasterfrom Apr 14, 2026
Merged
Refactor the toolbox widget to separate it from the ToolManager#2113cameronwhite merged 1 commit intomasterfrom
cameronwhite merged 1 commit intomasterfrom
Conversation
The toolbox widget was very closely coupled with other classes, especially the tool manager (which really shouldn't be managing UI widgets) - Remove the `ToolItem` from `BaseTool`. The toolbox widget instead maintains a mapping from tool to the button widgets, and is responsible for deciding how to create those buttons. - The ToolBoxButton class isn't really necessary now that it's internal to the toolbox widget - the toolbox widget can just create regular ToggleButton's without needing a subclass - Use a ToggleButton group to handle keeping only one of the buttons active, which is simpler than the previous approach. - Add an event on the ToolManager for activating a tool. This can also be used in the future for moving other UI logic (like the tool toolbar) out of the tool manager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolbox widget was very closely coupled with other classes, especially the tool manager (which really shouldn't be managing UI widgets)
Remove the
ToolItemfromBaseTool. The toolbox widget instead maintains a mapping from tool to the button widgets, and is responsible for deciding how to create those buttons.The ToolBoxButton class isn't really necessary now that it's internal to the toolbox widget - the toolbox widget can just create regular ToggleButton's without needing a subclass
Use a ToggleButton group to handle keeping only one of the buttons active, which is simpler than the previous approach.
Add an event on the ToolManager for activating a tool. This can also be used in the future for moving other UI logic (like the tool toolbar) out of the tool manager.