feat(mysql8): mysql8 compatibility + package upgrades#634
Merged
kschelonka merged 9 commits intomainfrom Nov 17, 2023
Merged
Conversation
kschelonka
changed the title
kschelonka
commented
Nov 17, 2023
|
|
||
| export const dbClient = knex({ | ||
| client: 'mysql', | ||
| client: 'mysql2', |
Contributor
Author
There was a problem hiding this comment.
the big change 💪
kschelonka
commented
Nov 17, 2023
kschelonka
force-pushed
the
mysql8-compat
branch
4 times, most recently
from
2ffde2a to
ecb91b2
Compare
kschelonka
force-pushed
the
mysql8-compat
branch
from
ecb91b2 to
c019996
Compare
kschelonka
force-pushed
the
mysql8-compat
branch
from
e08f357 to
f05b0b5
Compare
bassrock
approved these changes
Nov 17, 2023
Contributor
bassrock
left a comment
bassrock
left a comment
There was a problem hiding this comment.
LGTM so much house keeping
Contributor
Author
|
I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This snowballed into more upgrades, but includes the knex+mysql2 package upgrades for mysql8 compatibility.
See also: #635
Changes: