Track non-zero account holders #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… number of investors
# Conflicts: # contracts/modules/TransferManager/ExchangeTransferManager.sol # contracts/modules/TransferManager/GeneralTransferManager.sol # contracts/modules/TransferManager/ITransferManager.sol # contracts/tokens/SecurityToken.sol
pabloruiz55
suggested changes
May 10, 2018
|
|
||
| contract CountTransferManager is ITransferManager { | ||
|
|
||
| uint256 public holderCount; |
Contributor
There was a problem hiding this comment.
Can we rename this to maxHolderCount or holderCountLimit? readability purposes only.
| contract PercentageTransferManager is ITransferManager { | ||
| using SafeMath for uint256; | ||
|
|
||
| uint256 public holderPercentage; // percentage multiplied by 10**16 - e.g. 20% is 20 * 10**16 |
Contributor
There was a problem hiding this comment.
Can we rename this to maxHolderPercentage or holderPercentageLimit?
pabloruiz55
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - needs test cases