Correctly escape escape characters in String.Contains(), String.StartsWith() and String.EndsWith() translations if pattern doesn't contain wildcards.
#1951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtsWith()` and `String.EndsWith()` translations if pattern doesn't contain wildcards.
lauxjpn
force-pushed
the
fix/issue1943
branch
from
8bbd78a to
616006e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
String.Contains(),String.StartsWith()andString.EndsWith()translations only escaped the\escape char correctly, if the pattern also contained at least one wildcard character (%or_).Now, escape characters are always escaped (or at least as long as
NO_BACKSLASH_ESCAPESis not used; this would probably break our current implementations).Fixes #1943