Enhance copy loop functionality by allowing reference() usage in copy mode
#1287
+261
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gijsreyn
force-pushed
the
gh-1286/main/fix-reference-copy
branch
from
5d7597c to
5566b37
Compare
Member
|
@Gijsreyn can you fix the merge conflicts? |
Contributor
Author
|
@SteveL-MSFT - I'll pick it up when I'm back. |
…ithub.com/Gijsreyn/operation-methods into PowerShellgh-1286/main/fix-reference-copy
…into PowerShellgh-1286/main/fix-reference-copy
Contributor
Author
|
@SteveL-MSFT - I tried resolving the merge conflicts, but it looks like after the SSH merge, it started failing: https://github.com/PowerShell/DSC/actions/runs/20111826751 |
Member
|
@Gijsreyn I understand the problem and working on a fix |
Member
|
@Gijsreyn build issue resolved, but you still have some test failures |
Contributor
Author
|
@SteveL-MSFT - oops, I think I removed too much when fixing the merge conflict. Should be good to go! |
SteveL-MSFT
requested changes
Jan 7, 2026
|
|
||
| // Find the dependency in config.resources - it might be a copy loop template | ||
| // We need to find by type since the name is the template expression | ||
| if let Some(dependency_resource) = config.resources.iter().find(|r| r.resource_type == resource_type) { |
Member
There was a problem hiding this comment.
Do we need to handle the ase where the dependency doesn't exist?
| new_resource.properties = invoke_property_expressions(parser, context, Some(properties))?; | ||
| } | ||
| // Store copy loop context in resource tags for later use by reference() | ||
| let mut tags = new_resource.tags.clone().unwrap_or_default(); |
Member
There was a problem hiding this comment.
If you need to keep some context information I would prefer to put it under metadata/Microsoft.DSC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixed copy loops to work with
reference()function by preserving copy context during property evaluation. ModifiedcopyIndex()andreference()to accept copy context outside Copy mode, and stored loop indices in resource tags during unrolling then restored them before evaluating properties. Tests addedPR Context
Fix #1286