Skip to content

Set-Acl: Do not fail on untranslatable SID #21096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 1 commit into from
Jul 16, 2024
Merged

Set-Acl: Do not fail on untranslatable SID #21096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/System.Management.Automation/namespaces/FileSystemSecurity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,27 +168,29 @@ public void SetSecurityDescriptor(
{
// Get the security descriptor of the destination path
ObjectSecurity existingDescriptor = new FileInfo(path).GetAccessControl();
Type ntAccountType = typeof(System.Security.Principal.NTAccount);
// Use SecurityIdentifier to avoid having the below comparison steps
// fail when dealing with an untranslatable SID in the SD
Type identityType = typeof(System.Security.Principal.SecurityIdentifier);

AccessControlSections sections = AccessControlSections.All;

// If they didn't modify any audit information, don't try to set
// the audit section.
int auditRuleCount = sd.GetAuditRules(true, true, ntAccountType).Count;
int auditRuleCount = sd.GetAuditRules(true, true, identityType).Count;
if ((auditRuleCount == 0) &&
(sd.AreAuditRulesProtected == existingDescriptor.AreAccessRulesProtected))
{
sections &= ~AccessControlSections.Audit;
}

// If they didn't modify the owner, don't try to set that section.
if (sd.GetOwner(ntAccountType) == existingDescriptor.GetOwner(ntAccountType))
if (sd.GetOwner(identityType) == existingDescriptor.GetOwner(identityType))
{
sections &= ~AccessControlSections.Owner;
}

// If they didn't modify the group, don't try to set that section.
if (sd.GetGroup(ntAccountType) == existingDescriptor.GetGroup(ntAccountType))
if (sd.GetGroup(identityType) == existingDescriptor.GetGroup(identityType))
{
sections &= ~AccessControlSections.Group;
}
Expand Down
25 changes: 25 additions & 0 deletions test/powershell/Modules/Microsoft.PowerShell.Security/AclCmdlets.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,31 @@ Describe "Acl cmdlets are available and operate properly" -Tag CI {
$newrule | Should -Not -BeNullOrEmpty
}

It "Can edit SD that contains an orphaned SID" {
$badSid = [System.Security.Principal.SecurityIdentifier]::new("S-1-5-1234-5678")
$currentUserSid = [System.Security.Principal.WindowsIdentity]::GetCurrent().User

$testFilePath = "TestDrive:\pwsh-acl-test.txt"
$testFile = New-Item -Path $testFilePath -ItemType File -Value 'foo' -Force

# We should be able to set an SD entry to an untranslatable SID
$fileSecurity = $testFilePath | Get-Acl
$fileSecurity.SetGroup($badSid)
Set-Acl -Path $testFile -AclObject $fileSecurity

# We should be able to get the SD with an untranslatable SID
$setSD = Get-Acl -Path $testFile
$setSD.GetGroup([System.Security.Principal.SecurityIdentifier]) | Should -Be $badSid

# We should be able to set it back to a known SID
$setSD.SetGroup($currentUserSid)
Set-Acl -Path $testFile -AclObject $setSD

$actual = Get-Acl -Path $testFile
$actualGroup = $actual.GetGroup([System.Security.Principal.SecurityIdentifier])
$actualGroup | Should -Be $currentUserSid
}

AfterAll {
$PSDefaultParameterValues.Remove("It:Skip")
}
Expand Down