[release/v7.4] Add ability to capture MSBuild Binary logs when restore fails #24799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Capture binary logs * Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
TravisEz13
requested review from
adityapatwardhan,
anmenaga and
daxian-dbw
as code owners
TravisEz13
added
the
CL-BuildPackaging
Member
Author
|
/azp run PowerShell-CI-macos, PowerShell-CI-Linux, PowerShell-CI-Windows, PowerShell-CI-static-analysis, PSResourceGet ACR, PowerShell-Windows-Packaging-CI |
|
Azure Pipelines successfully started running 4 pipeline(s). |
adityapatwardhan
approved these changes
Jan 16, 2025
Contributor
|
📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #24128
This pull request includes changes to the
ENABLE_MSBUILD_BINLOGSparameter in the PowerShell build scripts and pipeline configuration. The most important changes include adding theENABLE_MSBUILD_BINLOGSparameter to the pipeline configuration and simplifying the conditional checks for this parameter in theRestore-PSPackagefunction.Pipeline configuration:
.pipelines/PowerShell-Coordinated_Packages-Official.yml: Added theENABLE_MSBUILD_BINLOGSparameter to enable MSBuild binary logs.Build script simplification:
build.psm1: Simplified the conditional checks forENABLE_MSBUILD_BINLOGSin theRestore-PSPackagefunction by removing the comparison to the string 'true'. [1] [2]