Revert manual pin of Newtonsoft.Json #1962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RansomVO
approved these changes
Nov 29, 2022
andyleejordan
force-pushed
the
andschwa/revert-pin
branch
from
93286ff to
142b7f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning this in #1947 before getting our transitive dependencies in order seems to be the root cause of PowerShell/vscode-powershell#4278 and possibly also PowerShell/vscode-powershell#4283. We're going to revert until we get OmniSharp's dependency sorted, and test in preview with users if those issues are resolved.