Skip to content

Conversation

@SeeminglyScience
Copy link
Collaborator

Fixes #1959

The code on the client expects DefaultChoices to never be null. If you send null, it tries to access the property length on what would be an array.

Fixes PowerShell#1959

The code on the client expects DefaultChoices to never be `null`. If you
send `null`, it tries to access the property `length` on what would be
an array.
@SeeminglyScience SeeminglyScience requested a review from a team December 28, 2022 20:36
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

@andyleejordan andyleejordan added Issue-Bug A bug to squash. Area-API labels Jan 3, 2023
@andyleejordan andyleejordan merged commit 4517101 into PowerShell:main Jan 3, 2023
@SeeminglyScience SeeminglyScience deleted the SeeminglyScience/issue1959 branch January 3, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-API Issue-Bug A bug to squash.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequestRefactor hotkey throws an InternalError when calling $CommandSuite.RequestRefactor($PSCmdlet)

2 participants