Add PowerShell 7.4 SDK and net8.0 framework
#2114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the target framework for the end-to-end test client.
.NET 8.0 suggests quite a few more of these "fixes" which we ought to do, but not quite yet!
andyleejordan
added
Issue-Enhancement
andyleejordan
force-pushed
the
andyleejordan/ps74-net80
branch
3 times, most recently
from
d45a05b to
bc8ff55
Compare
…th` bug We've known inheriting that environment variable breaks stuff, but now it breaks tests too.
This will additionally run the unit tests against the PowerShell 7.2 and 7.3 SDKs, and the end-to-end tests under Constrained Language Mode.
andyleejordan
force-pushed
the
andyleejordan/ps74-net80
branch
from
bc8ff55 to
c3570ba
Compare
SydneyhSmith
approved these changes
Dec 15, 2023
So we still ensure _everything_ works when merging (possibly multiple PRs at once), but aren't stuck running the long set of tests for each push and PR.
andyleejordan
force-pushed
the
andyleejordan/ps74-net80
branch
from
c3570ba to
dccb589
Compare
andyleejordan
force-pushed
the
andyleejordan/ps74-net80
branch
from
7e344d5 to
41e998c
Compare
Since `dotnet --version` can return e.g. "8.0.100 [C:\hostedtoolcache\windows\dotnet\sdk]" on CI. Also it should be requiring 8.0 now!
andyleejordan
force-pushed
the
andyleejordan/ps74-net80
branch
from
41e998c to
57ebb47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tech debt...