Skip to content

Skip auto-update on unsupported Windows architectures #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 1 commit into from
Dec 2, 2022
Merged

Skip auto-update on unsupported Windows architectures #4298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/features/UpdatePowerShell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { LanguageClient } from "vscode-languageclient/node";
import { Logger } from "../logging";
import { SessionManager } from "../session";
import { changeSetting } from "../settings";
import { isMacOS, isWindows } from "../utils";
import { isLinux, isMacOS, isWindows } from "../utils";
import { EvaluateRequestType } from "./Console";

const streamPipeline = util.promisify(stream.pipeline);
Expand Down Expand Up @@ -113,7 +113,8 @@ export async function InvokePowerShellUpdateCheck(
}). The current latest release is ${release.version.raw
}.`;

if (process.platform === "linux") {
// Cannot auto-install for Linux or Windows that isn't x86 or x64.
if (isLinux || (isWindows && (arch !== "X86" && arch !== "X64"))) {
void logger.writeAndShowInformation(`${commonText} We recommend updating to the latest version.`);
return;
}
Expand All @@ -134,7 +135,7 @@ export async function InvokePowerShellUpdateCheck(
// Yes choice.
case 0:
if (isWindows) {
const msiMatcher = arch === "x86" ?
const msiMatcher = arch === "X86" ?
"win-x86.msi" : "win-x64.msi";

// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand Down