fix(report): compare differences in both context direction#38
Merged
Conversation
…profiles The formatDetailedValue() early-return guard was checking only the left side (Context A) for emptiness and returning "No values configured" for both sides. This caused the Detailed Comparison panel to display "No values configured" on both sides even when Context B had profiles. Fix by checking both sides independently: only short-circuit when both are empty, and normalise single-falsy-element arrays to [] before passing them to Diff.diffArrays so the library produces the correct diff. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formatDetailedValue() early-return guard was checking only the left side (Context A) for emptiness and returning "No values configured" for both sides. This caused the Detailed Comparison panel to display "No values configured" on both sides even when Context B had profiles.
Fix by checking both sides independently: only short-circuit when both are empty, and normalise single-falsy-element arrays to [] before passing them to Diff.diffArrays so the library produces the correct diff.