type annotation has some error

[asukaminato0721]

Bug summary

prefect/src/integrations/prefect-dbt/tests/cli/test_commands.py

Lines 256 to 266 in 9f8b7b6

	@pytest.fixture
	def dbt_runner_freshness_success(
	monkeypatch: pytest.MonkeyPatch, mock_dbt_runner_freshness_success: dbtRunnerResult
	) -> None:
	_mock_dbt_runner_freshness_success = MagicMock(
	return_value=mock_dbt_runner_freshness_success
	)
	monkeypatch.setattr(
	"dbt.cli.main.dbtRunner.invoke", _mock_dbt_runner_freshness_success
	)
	return _mock_dbt_runner_freshness_success

this return a MagicMock, not None.

Version info

main branch.

Additional context

disclaim: implementing type check for pytest fixture.

related background is here.

facebook/pyrefly#2075 (comment)

[desertaxle]

Thanks for the issue @asukaminato0721! Do you want to submit a PR to fix this?

[asukaminato0721]

This can be a good first issue for others.

[ashwanth0110]

Hi! I can confirm this issue is still present in the current codebase.

I've verified that the dbt_runner_freshness_success fixture on lines 256-268 in src/integrations/prefect-dbt/tests/cli/test_commands.py still has the incorrect type annotation -> None when it actually returns a MagicMock object.

The fix is straightforward:

• Change line 258 from ) -> None: to ) -> MagicMock:
• MagicMock is already imported at the top of the file (line 3)

I'd be happy to submit a PR to fix this. Is this issue still available to work on?

Thanks!