Add new type column on cart_rule_product_rule_group table

[jolelievre]

Questions	Answers
Description?	Add new type column on cart_rule_product_rule_group table
Type?	new feature
BC breaks?	no
Deprecations?	no
Fixed ticket?	~
Sponsor company	~
How to test?	Upgrade from a lower version to 9.1.0, the table cart_rule_product_rule_group should contain a new enum column, all existing rows have the default value at_least_one_product_rule

Related PR from the core:
PrestaShop/PrestaShop#39418

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jolelievre]

I leave it as a draft until the core PR is merged

[AureRita]

Hello @jolelievre

Thank you for your PR, I tested it and I have this result :

If I read well, you want a enum column, currently we have a new row type with info : "enum" and the default value wanted "at_least_one_product_rule". For me it's not what we want to have.

Waiting for your feeback

[jolelievre]

@AureRita what you describe, what you show, and what is in the description all seem to be in sync to me 🤔
So I don't understand what the problem is for you?

[AureRita]

@jolelievre For me, there is a reversal between the columns and rows according to the description.

If that's how it has to be for you, I'll approve the PR.

Waiting for your feedback to approve it (a 👍 works for me)

[Touxten]

Hello @AureRita

You have to check when you open the table.
Here you check the database structure.

[Quetzacoalt91]

@Touxten you can see from the screenshot that the structure has been checked.

@AureRita when opening the structure of a database table, columns are displayed as lines. The description from Jo is q bit confusing but you should have a "column" called type, with the following type: enum(...)

[Touxten]

I see my english is bad :)

Je voulais dire vous devez ouvrir la table et vérifier que la nouvelle colonne à bien la même valeur par défaut pour toutes les entrées.

[Quetzacoalt91]

Nah sorry I misread your message, it was clear. 👍

[AureRita]

Hi @jolelievre

Thank you for your PR, I tested it and it seems to works as you can see :

Tested from :
8.0.4 to 9.1.0(develop)

Because the PR seems to works as expected, It's QA ✔️

Thank you