Add a new type to product rule enum#1457
Merged
Quetzacoalt91 merged 1 commit intoPrestaShop:devfrom Nov 28, 2025
Merged
Conversation
Contributor
tleon
commented
Sep 4, 2025
tleon
commented
| Questions | Answers |
|---|---|
| Description? | Add a new type to product rule enum |
| Type? | new feature |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #38743 |
| Sponsor company | PrestaShop SA |
| How to test? | CI green |
|
Quetzacoalt91
approved these changes
Sep 4, 2025
Quetzacoalt91
added
Blocked
Member
|
@tleon can you please rebase? There are 3 CI workflow that fail should be fixed. |
Member
|
@tleon please rebase |
tleon
force-pushed
the
Issue-38743-add-type-to-product-rule-enum
branch
from
734fabd to
d266daa
Compare
Contributor
Author
|
Sorry I took some time to rebase this ;) |
|
Quetzacoalt91
approved these changes
Nov 26, 2025
AureRita
approved these changes
Nov 28, 2025
Contributor
AureRita
left a comment
AureRita
left a comment
There was a problem hiding this comment.
Hi @tleon
Thank you for your PR, I tested it and it seems to works as you can see :
Capture.video.du.2025-11-28.11-51-25.mp4
Tested from :
9.0.1 to 9.1.0
8.2 to 9.1.0
8.0.4 to 9.1.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
AureRita
added
QA ✔️
github-project-automation
bot
moved this from Ready for review
to Merged
in PR Dashboard
Collaborator
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.