Support for the new "recommended" property#1460
Merged
Quetzacoalt91 merged 5 commits intoPrestaShop:devfrom Sep 19, 2025
Merged
Support for the new "recommended" property#1460Quetzacoalt91 merged 5 commits intoPrestaShop:devfrom
Quetzacoalt91 merged 5 commits intoPrestaShop:devfrom
Conversation
M0rgan01
force-pushed
the
use-recommended-version
branch
5 times, most recently
from
a285ac7 to
f9588cf
Compare
M0rgan01
changed the title
Nakahiru
approved these changes
Sep 10, 2025
M0rgan01
force-pushed
the
use-recommended-version
branch
from
f9588cf to
2b9dfae
Compare
ga-devfront
previously approved these changes
Sep 10, 2025
Member
|
Removed milestone 7.4.0 as the version is already under QA review for release. |
M0rgan01
force-pushed
the
use-recommended-version
branch
2 times, most recently
from
9ec8860 to
7f35e63
Compare
M0rgan01
force-pushed
the
use-recommended-version
branch
from
7f35e63 to
84bd65b
Compare
ga-devfront
previously approved these changes
Sep 11, 2025
M0rgan01
force-pushed
the
use-recommended-version
branch
from
84bd65b to
32e528c
Compare
M0rgan01
force-pushed
the
use-recommended-version
branch
from
32e528c to
3df2026
Compare
Add v10 in test fixtures
|
Quetzacoalt91
approved these changes
Sep 16, 2025
ingridusta
approved these changes
Sep 19, 2025
ingridusta
left a comment
ingridusta
left a comment
There was a problem hiding this comment.
Hello @M0rgan01,
Several ps versions have been tested to check the modal display (or not) and which version is proposed to the merchant :
- 8.2.1-8.1-fpm-bookworm-nginx : ok modal ✅
- 8.2.3-8.1-nginx : no modal ✅
- 8.1.5-debian-nginx : ok modal ✅
- 8.0.5-7.2-fpm-alpine-nginx : ok modal ✅
- 1.7.3.4-7.1-fpm-alpine-nginx : ok modal ✅
- 1.7.5.0-7.2-fpm-alpine-nginx : ok modal ✅
- 9.0.0-8.1-fpm-bookworm-nginx : no modal ✅
According to all those tests, your pr is QA approved ✅
ingridusta
added
QA ✔️
github-project-automation
bot
moved this from Ready for review
to Merged
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.