Skip to content

Prepare change of index with pre-deletion of duplicates in image_type table #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quetzacoalt91 merged 2 commits into from
Oct 20, 2025
Merged

Prepare change of index with pre-deletion of duplicates in image_type table #1494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8c9e54
Prepare change of index with pre-deletion of duplicates in image_type…
Quetzacoalt91 Oct 10, 2025
518d626
Nest 2 times the subquery
Quetzacoalt91 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 110 additions & 0 deletions upgrade/php/ps_901_set_unicity_on_image_type.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
<?php
/**
* Copyright since 2007 PrestaShop SA and Contributors
* PrestaShop is an International Registered Trademark & Property of PrestaShop SA
*
* NOTICE OF LICENSE
*
* This source file is subject to the Academic Free License version 3.0
* that is bundled with this package in the file LICENSE.md.
* It is also available through the world-wide-web at this URL:
* https://opensource.org/licenses/AFL-3.0
* If you did not receive a copy of the license and are unable to
* obtain it through the world-wide-web, please send an email
* to license@prestashop.com so we can send you a copy immediately.
*
* @author PrestaShop SA and Contributors <contact@prestashop.com>
* @copyright Since 2007 PrestaShop SA and Contributors
* @license https://opensource.org/licenses/AFL-3.0 Academic Free License version 3.0
*/

use PrestaShop\Module\AutoUpgrade\Database\DbWrapper;

/*
Example of PREFIX_image_type from a shop installed on PS 9.0.0
+---------------+-------------------+-------+--------+----------+------------+---------------+-----------+--------+-------------+
| id_image_type | name | width | height | products | categories | manufacturers | suppliers | stores | theme_name |
+---------------+-------------------+-------+--------+----------+------------+---------------+-----------+--------+-------------+
| 1 | cart_default | 125 | 125 | 1 | 0 | 0 | 0 | 0 | classic |
| 2 | small_default | 98 | 98 | 1 | 1 | 1 | 1 | 0 | classic |
| 3 | medium_default | 452 | 452 | 1 | 0 | 1 | 1 | 0 | classic |
| 4 | home_default | 250 | 250 | 1 | 0 | 0 | 0 | 0 | classic |
| 5 | large_default | 800 | 800 | 1 | 0 | 1 | 1 | 0 | classic |
| 6 | category_default | 141 | 180 | 0 | 1 | 0 | 0 | 0 | classic |
| 7 | stores_default | 170 | 115 | 0 | 0 | 0 | 0 | 1 | classic |
| 8 | cart_default | 125 | 125 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 9 | small_default | 98 | 98 | 1 | 1 | 1 | 1 | 0 | hummingbird |
| 10 | medium_default | 452 | 452 | 1 | 0 | 1 | 1 | 0 | hummingbird |
| 11 | large_default | 800 | 800 | 1 | 0 | 1 | 1 | 0 | hummingbird |
| 12 | home_default | 250 | 250 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 13 | category_default | 141 | 180 | 0 | 1 | 0 | 0 | 0 | hummingbird |
| 14 | stores_default | 287 | 160 | 0 | 0 | 0 | 0 | 1 | hummingbird |
| 15 | default_xs | 160 | 160 | 1 | 1 | 1 | 1 | 0 | hummingbird |
| 16 | default_sm | 216 | 216 | 1 | 1 | 0 | 0 | 0 | hummingbird |
| 17 | default_md | 261 | 261 | 1 | 1 | 1 | 1 | 0 | hummingbird |
| 18 | default_lg | 336 | 336 | 1 | 1 | 0 | 0 | 0 | hummingbird |
| 19 | default_xl | 400 | 400 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 20 | product_main | 720 | 720 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 21 | category_cover | 1000 | 200 | 0 | 1 | 0 | 0 | 0 | hummingbird |
| 22 | product_main_2x | 1440 | 1440 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 23 | category_cover_2x | 2000 | 400 | 0 | 1 | 0 | 0 | 0 | hummingbird |
+---------------+-------------------+-------+--------+----------+------------+---------------+-----------+--------+-------------+
23 rows in set (0.001 sec)

Example of PREFIX_image_type from a shop updated to PS 9.0.0
+---------------+-------------------+-------+--------+----------+------------+---------------+-----------+--------+-------------+
| id_image_type | name | width | height | products | categories | manufacturers | suppliers | stores | theme_name |
+---------------+-------------------+-------+--------+----------+------------+---------------+-----------+--------+-------------+
| 1 | cart_default | 125 | 125 | 1 | 0 | 0 | 0 | 0 | NULL |
| 2 | small_default | 98 | 98 | 1 | 1 | 1 | 1 | 0 | NULL |
| 3 | medium_default | 452 | 452 | 1 | 0 | 1 | 1 | 0 | NULL |
| 4 | home_default | 250 | 250 | 1 | 0 | 0 | 0 | 0 | NULL |
| 5 | large_default | 800 | 800 | 1 | 0 | 1 | 1 | 0 | NULL |
| 6 | category_default | 141 | 180 | 0 | 1 | 0 | 0 | 0 | NULL |
| 7 | stores_default | 170 | 115 | 0 | 0 | 0 | 0 | 1 | NULL |
| 8 | cart_default | 125 | 125 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 9 | small_default | 98 | 98 | 1 | 1 | 1 | 1 | 0 | hummingbird |
| 10 | medium_default | 452 | 452 | 1 | 0 | 1 | 1 | 0 | hummingbird |
| 11 | home_default | 250 | 250 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 12 | large_default | 800 | 800 | 1 | 0 | 1 | 1 | 0 | hummingbird |
| 13 | category_default | 141 | 180 | 0 | 1 | 0 | 0 | 0 | hummingbird |
| 14 | stores_default | 170 | 115 | 0 | 0 | 0 | 0 | 1 | hummingbird |
| 15 | default_xs | 120 | 120 | 1 | 1 | 1 | 1 | 0 | hummingbird |
| 16 | default_s | 160 | 160 | 1 | 1 | 0 | 0 | 0 | hummingbird |
| 17 | default_m | 200 | 200 | 1 | 0 | 1 | 1 | 1 | hummingbird |
| 18 | default_md | 320 | 320 | 1 | 1 | 0 | 0 | 0 | hummingbird |
| 19 | default_xl | 400 | 400 | 1 | 0 | 0 | 0 | 1 | hummingbird |
| 20 | product_main | 720 | 720 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 21 | category_cover | 1000 | 200 | 0 | 1 | 0 | 0 | 0 | hummingbird |
| 22 | product_main_2x | 1440 | 1440 | 1 | 0 | 0 | 0 | 0 | hummingbird |
| 23 | category_cover_2x | 2000 | 400 | 0 | 1 | 0 | 0 | 0 | hummingbird |
+---------------+-------------------+-------+--------+----------+------------+---------------+-----------+--------+-------------+
23 rows in set (0.001 sec)
*/

/**
* @throws \PrestaShop\Module\AutoUpgrade\Exceptions\UpdateDatabaseException
*/
function ps_901_set_unicity_on_image_type(): bool
{
// Request can't be nested because of this error:
// ERROR 1267 (HY000): Illegal mix of collations (utf8mb4_general_ci,IMPLICIT) and (utf8mb4_unicode_ci,IMPLICIT) for operation '='
// Need to retrieve the list of themes in a dedicated request.
$themesListResult = DbWrapper::executeS('SELECT `theme_name` FROM ' . _DB_PREFIX_ . 'shop GROUP BY `theme_name`');

$themesList = array_column((array) $themesListResult, 'theme_name');

// Keep most recent values of duplicated image type related to active themes.
// This request covers the case where different shops on a multi-environment have different themes, where we will keep the highest ID.
// Subrequest is nested 2 times to avoid Error 1093 "You can't specify target table 'image_type' for update in FROM clause"
return DbWrapper::execute('DELETE FROM ' . _DB_PREFIX_ . 'image_type
WHERE id_image_type NOT IN (
SELECT `max_id_image_type` FROM (
SELECT MAX(`id_image_type`) AS `max_id_image_type`
FROM ' . _DB_PREFIX_ . 'image_type
WHERE `theme_name` IS NULL OR `theme_name` IN ("' . implode('", "', $themesList) . '")
GROUP BY `name`
) AS derived
)
');
}
1 change: 1 addition & 0 deletions upgrade/sql/9.0.1.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ ON DUPLICATE KEY UPDATE `value` = VALUES(`value`);

/* Remove theme_name field from image_type table */
/* https://github.com/PrestaShop/PrestaShop/pull/39554 */
/* PHP:ps_901_set_unicity_on_image_type(); */;
ALTER TABLE `PREFIX_image_type`
DROP COLUMN `theme_name`,
DROP INDEX `UNIQ_907C95215E237E0614E48A3B`,
Expand Down