Skip to content

Create additional autoloader for PHP 8.1+#1512

Merged
Quetzacoalt91 merged 2 commits intoPrestaShop:devfrom
Quetzacoalt91:change-deps-2
Nov 12, 2025
Merged

Create additional autoloader for PHP 8.1+#1512
Quetzacoalt91 merged 2 commits intoPrestaShop:devfrom
Quetzacoalt91:change-deps-2

Conversation

@Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Oct 23, 2025

Questions Answers
Description? While attempting fixing others issues we have on the project, regarding modules updates or assets installation, we encounter conflicts on symfony/console when we load Symfony while updating in CLI. This is caused by the dependencies we have on our main composer.json that lack the strict typing we are supposed to have on PrestaShop v9.
To improve the situation, we create a variant of our dependencies that will be loaded first in CLI while running PHP 8.1+. This is hacky but this allows us to keep one module to maintain for PrestaShop 1.7 ~ 9.
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? CI is still green. Furthermore, this change should make the update processes to work again. Some the PRs currently under review fail, and must succeed with this one as we should find out in the test: #1504

@Quetzacoalt91 Quetzacoalt91 added this to the 7.5.0 milestone Oct 28, 2025
@Quetzacoalt91 Quetzacoalt91 added Blocked Status: The issue is blocked by another task and removed waiting for QA labels Oct 31, 2025
@Quetzacoalt91 Quetzacoalt91 removed the Blocked Status: The issue is blocked by another task label Nov 4, 2025
ga-devfront
ga-devfront previously approved these changes Nov 4, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@AureRita AureRita self-assigned this Nov 12, 2025
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91

Thank you for your PR, I tested it and it seems to works .

Tested from :
1.7.8.9 to 8.2.3 to 9.0.1
8.2.2 classic to 8.2.3
8.2.2 classic to 9.0.1 with php 8.1
8.2.2 classic to 9.0.1 with php 8.3
8.0.3 to 8.2.3
8.0.3 to 9.0.1

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita added QA ✔️ Status: Check done, Code approved and removed waiting for QA labels Nov 12, 2025
@Quetzacoalt91 Quetzacoalt91 merged commit 6ccc3f0 into PrestaShop:dev Nov 12, 2025
60 of 61 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Nov 12, 2025
@Quetzacoalt91 Quetzacoalt91 deleted the change-deps-2 branch November 12, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: Improvement QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants