Skip to content

Add nullable type on implicit types#1522

Merged
Quetzacoalt91 merged 1 commit intoPrestaShop:devfrom
Quetzacoalt91:fix-deprecation-nullable-param
Jan 12, 2026
Merged

Add nullable type on implicit types#1522
Quetzacoalt91 merged 1 commit intoPrestaShop:devfrom
Quetzacoalt91:fix-deprecation-nullable-param

Conversation

@Quetzacoalt91
Copy link
Member

Questions Answers
Description? <b>Deprecated</b>: PrestaShop\Module\AutoUpgrade\Models\PrestashopRelease::__construct(): Implicitly marking parameter $distribution as nullable is deprecated, the explicit nullable type must be used instead in <b>modules/autoupgrade/classes/Models/PrestashopRelease.php</b> on line <b>47</b><br />
Type? bug fix
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fix reported issue via Error reporting modal of Update Assistant
Sponsor company @PrestaShopCorp
How to test? Running PrestaShop on PHP 8.4 with the error reporting as -1, plus _PS_DISPLAY_COMPATIBILITY_WARNING_ as true in config/defines.inc.php should trigger the error on the dev branch.

@Quetzacoalt91 Quetzacoalt91 self-assigned this Nov 10, 2025
@Quetzacoalt91 Quetzacoalt91 added the bug Type: Bug fix label Nov 10, 2025
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Nov 10, 2025
@Quetzacoalt91 Quetzacoalt91 force-pushed the fix-deprecation-nullable-param branch 2 times, most recently from 6216cb8 to 876c74b Compare November 14, 2025 14:32
@sonarqubecloud
Copy link

@AureRita
Copy link
Contributor

AureRita commented Dec 1, 2025

Hello @Quetzacoalt91

Thank you for your PR, I tested it and with php 8.4, event without the error reporting as -1, i've many other deprecated call that give me an error on update assistant as you can see :

Capture.video.du.2025-11-28.15-19-26.mp4

I expect that screen 'll help you to find the different part of the deprecation

Waiting for feedbacks

@Quetzacoalt91
Copy link
Member Author

All these reports are related to files stored in vendor/, on which I have no control because of the PHP compatibility range we currently have.

This is fine at the moment and will be handled in a broader topic.

@Quetzacoalt91 Quetzacoalt91 force-pushed the fix-deprecation-nullable-param branch from 876c74b to b3eddc4 Compare January 2, 2026 14:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 2, 2026

Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91

Thank you for your PR, I tested it and it seems to works as you can see :

Capture d’écran du 2026-01-12 17-14-17

(on top of the screen, you have a previous version with the error underline, on bot you have the correction)

Tested on :
9.0.0 php 8.4

FI: as said before "reports are related to files stored in vendor/" are not related to this PR, so it not blocked this PR

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita added QA ✔️ Status: Check done, Code approved and removed waiting for QA labels Jan 12, 2026
@Quetzacoalt91 Quetzacoalt91 added this to the 7.6.0 milestone Jan 12, 2026
@Quetzacoalt91 Quetzacoalt91 merged commit ffa6bbe into PrestaShop:dev Jan 12, 2026
56 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Jan 12, 2026
@Quetzacoalt91 Quetzacoalt91 deleted the fix-deprecation-nullable-param branch January 13, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type: Bug fix QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants