Add nullable type on implicit types#1522
Conversation
6216cb8 to
876c74b
Compare
|
|
Hello @Quetzacoalt91 Thank you for your PR, I tested it and with php 8.4, event without the error reporting as -1, i've many other deprecated call that give me an error on update assistant as you can see : Capture.video.du.2025-11-28.15-19-26.mp4I expect that screen 'll help you to find the different part of the deprecation Waiting for feedbacks |
|
All these reports are related to files stored in This is fine at the moment and will be handled in a broader topic. |
876c74b to
b3eddc4
Compare
|
There was a problem hiding this comment.
Thank you for your PR, I tested it and it seems to works as you can see :
(on top of the screen, you have a previous version with the error underline, on bot you have the correction)
Tested on :
9.0.0 php 8.4
FI: as said before "reports are related to files stored in vendor/" are not related to this PR, so it not blocked this PR
Because the PR seems to works as expected, It's QA ✔️
Thank you



<b>Deprecated</b>: PrestaShop\Module\AutoUpgrade\Models\PrestashopRelease::__construct(): Implicitly marking parameter $distribution as nullable is deprecated, the explicit nullable type must be used instead in <b>modules/autoupgrade/classes/Models/PrestashopRelease.php</b> on line <b>47</b><br />_PS_DISPLAY_COMPATIBILITY_WARNING_astruein config/defines.inc.php should trigger the error on thedevbranch.