Skip to content

Avoid impacting statistics of succesfull updates with test cases#1541

Merged
Quetzacoalt91 merged 2 commits intoPrestaShop:devfrom
Quetzacoalt91:disable-analytics-in-tests
Jan 7, 2026
Merged

Avoid impacting statistics of succesfull updates with test cases#1541
Quetzacoalt91 merged 2 commits intoPrestaShop:devfrom
Quetzacoalt91:disable-analytics-in-tests

Conversation

@Quetzacoalt91
Copy link
Member

@Quetzacoalt91 Quetzacoalt91 commented Nov 28, 2025

Questions Answers
Description? Do not send test cases to statistics, as we want to know how healthy are updates from actual shops.
Type? improvement
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? To check that UI tests do not send anymore events to Segment, make a PS_VERSION=8.2.1 docker compose up -d from the command line, then docker exec -ti -u www-data prestashop php modules/autoupgrade/bin/console backup:create admin-dev. Check Segment with and without the env var.

@Quetzacoalt91 Quetzacoalt91 self-assigned this Nov 28, 2025
@Quetzacoalt91 Quetzacoalt91 added the enhancement Type: Improvement label Nov 28, 2025
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Nov 28, 2025
Nakahiru
Nakahiru previously approved these changes Nov 28, 2025
ga-devfront
ga-devfront previously approved these changes Nov 28, 2025
@Quetzacoalt91 Quetzacoalt91 added this to the 7.5.0 milestone Nov 28, 2025
@ingridusta ingridusta self-assigned this Dec 1, 2025
@AureRita AureRita self-assigned this Dec 1, 2025
@ingridusta ingridusta removed their assignment Dec 1, 2025
@Quetzacoalt91 Quetzacoalt91 changed the title Avoid impacting statistics or succesfull updates with test cases Avoid impacting statistics of succesfull updates with test cases Dec 1, 2025
@AureRita
Copy link
Contributor

AureRita commented Dec 2, 2025

Hi @Quetzacoalt91

I tested your PR and when I do a backup with the command
docker exec -ti -u www-data prestashop php modules/autoupgrade/bin/console backup:create admin-dev
I don't have any call on segment but when I do it on web version, I've different segment call so this will send test cases to statistics.

as you can see :

Capture.video.du.2025-12-02.11-05-39.mp4

Because of that, currently I can't approve this PR

Waiting for feedback

@Quetzacoalt91 Quetzacoalt91 force-pushed the disable-analytics-in-tests branch from 4f0e024 to a7fec3e Compare December 2, 2025 16:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

@AureRita
Copy link
Contributor

AureRita commented Dec 3, 2025

Hi @Quetzacoalt91

Thank you for your PR, I tested it and I still have the segment call on web version, as you can see it :

Capture.video.du.2025-12-03.11-30-36.mp4

I checked if I have the good version of the PR and I still have the parameters ' PS_URL_TRACKING : 0 '

Waiting for feedback

@Quetzacoalt91
Copy link
Member Author

To be checked as a bug, not a regression. The change we're dealing with here is about the events sent from the backend, not the front end

@Quetzacoalt91
Copy link
Member Author

@AureRita I need you to test the the events sent from the back end.
The events from the front end are sent whatever the value of PS_URL_TRACKING, this can be improved in a dedicated PR

@Quetzacoalt91 Quetzacoalt91 removed this from the 7.5.0 milestone Dec 3, 2025
@Quetzacoalt91 Quetzacoalt91 added this to the 7.6.0 milestone Dec 3, 2025
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91

Thank you for your PR, I tested it and it seems to works as you can see :

Capture.video.du.2025-12-04.17-50-51.mp4
Capture.video.du.2025-12-04.17-42-17.mp4

I checked and only js_fe_prod are submitted

Tested from :
8.21 to 9.0.1

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita added QA ✔️ Status: Check done, Code approved and removed waiting for QA labels Dec 4, 2025
@Quetzacoalt91 Quetzacoalt91 added the Blocked Status: The issue is blocked by another task label Dec 10, 2025
@Quetzacoalt91
Copy link
Member Author

Waiting of the release of 7.5.0 before merging this PR

@Quetzacoalt91 Quetzacoalt91 removed the Blocked Status: The issue is blocked by another task label Jan 7, 2026
@Quetzacoalt91 Quetzacoalt91 merged commit 4d7ed07 into PrestaShop:dev Jan 7, 2026
56 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Jan 7, 2026
@ps-jarvis ps-jarvis moved this from Merged to Ready for review in PR Dashboard Jan 7, 2026
@Quetzacoalt91 Quetzacoalt91 deleted the disable-analytics-in-tests branch January 7, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Type: Improvement QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants