Skip to content

Allow a module to be updated even if it does not have a config.xml file#1547

Merged
Quetzacoalt91 merged 3 commits intoPrestaShop:devfrom
Quetzacoalt91:config-xml-check
Jan 12, 2026
Merged

Allow a module to be updated even if it does not have a config.xml file#1547
Quetzacoalt91 merged 3 commits intoPrestaShop:devfrom
Quetzacoalt91:config-xml-check

Conversation

@Quetzacoalt91
Copy link
Member

Questions Answers
Description? When running #1528 for tests, I discovered that some modules were not visible even though they are installed on the shop. This happens when the cache file config.xml does not exist. Because we don't rely anymore on the XML content the related check can be removed, allowing more modules to be updated.
Type? bug fix
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? Delete the config.xml file of specific modules. They must be updated even if the file is missing for their repository.

@Quetzacoalt91 Quetzacoalt91 self-assigned this Dec 12, 2025
@Quetzacoalt91 Quetzacoalt91 added the bug Type: Bug fix label Dec 12, 2025
@Quetzacoalt91 Quetzacoalt91 added this to the 7.6.0 milestone Dec 12, 2025
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Dec 12, 2025
@Quetzacoalt91 Quetzacoalt91 changed the title Config xml check Allow a module to be updated even if it does not have a config.xml file Dec 12, 2025
Hlavtox
Hlavtox previously approved these changes Dec 12, 2025
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. The config.xml file is only required for addons. Shops will create config_isocodeoflanguage.xml automatically. :-)

Nakahiru
Nakahiru previously approved these changes Jan 7, 2026
ga-devfront
ga-devfront previously approved these changes Jan 7, 2026
@AureRita AureRita self-assigned this Jan 12, 2026
@sonarqubecloud
Copy link

@Touxten Touxten requested a review from ga-devfront January 12, 2026 11:29
Copy link
Contributor

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Quetzacoalt91

Thank you for your PR, I tested it and it seems to works as you can see :

Capture d’écran du 2026-01-12 15-38-11
Capture.video.du.2026-01-12.12-24-34.mp4

Tested from :
8.1.4 to 8.2.3 (each version on Open source and with module ps_mbo)
9.0.0 to 9.0.2

Because the PR seems to works as expected, It's QA ✔️

Thank you

@AureRita AureRita added QA ✔️ Status: Check done, Code approved and removed waiting for QA labels Jan 12, 2026
@Quetzacoalt91 Quetzacoalt91 merged commit 7dc1aa3 into PrestaShop:dev Jan 12, 2026
56 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Jan 12, 2026
@ps-jarvis ps-jarvis moved this from Merged to Ready for review in PR Dashboard Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type: Bug fix QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants