Change how we get the Request object#1590
Merged
Quetzacoalt91 merged 1 commit intoPrestaShop:devfrom Jan 20, 2026
Merged
Conversation
Quetzacoalt91
force-pushed
the
request-get
branch
from
8a00cd5 to
5db6ac7
Compare
Quetzacoalt91
force-pushed
the
request-get
branch
6 times, most recently
from
0319f95 to
18c7de6
Compare
Quetzacoalt91
force-pushed
the
request-get
branch
from
18c7de6 to
1197a31
Compare
|
ga-devfront
approved these changes
Jan 19, 2026
AureRita
approved these changes
Jan 19, 2026
Contributor
AureRita
left a comment
AureRita
left a comment
There was a problem hiding this comment.
Hi @
Thank you for your PR, I tested it and it seems to works as you can see :
Capture.video.du.2026-01-19.18-04-53.mp4
Tested on :
9.0.2
Because the PR seems to works as expected, It's QA ✔️
Thank you
AureRita
added
QA ✔️
github-project-automation
bot
moved this from Ready for review
to Merged
in PR Dashboard
|
FYI following v7.6 beta release tests, it's not working on 8.2.3 neither (but works on 9.0.3 😉). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- It appears the service "request_stack" may be non-existing on PS 1.7 because of the limited integration of Symfony on these versions, especially on legacy pages
- The request stack may have no requests in their list.
In these cases, we still rely on the use ofRequest::createFromGlobals()with the risk of failures on pages where a file is uploaded. The issue is not completely fixed but mitigated.