Skip to content

Fix loading of container on very old versions of PS#1621

Merged
Quetzacoalt91 merged 1 commit intoPrestaShop:devfrom
Quetzacoalt91:fix-uninstall-on-old-ps-versions
Jan 29, 2026
Merged

Fix loading of container on very old versions of PS#1621
Quetzacoalt91 merged 1 commit intoPrestaShop:devfrom
Quetzacoalt91:fix-uninstall-on-old-ps-versions

Conversation

@Quetzacoalt91
Copy link
Member

Questions Answers
Description? While manipulating the module before running UI tests, it appeared we have an issue when uninstalling it.
Type? bug fix
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
Sponsor company @PrestaShopCorp
How to test? Uninstalling the module on PS 1.7.2.1 works.

Reported error

Capture d’écran du 2026-01-28 14-31-28

@Quetzacoalt91 Quetzacoalt91 self-assigned this Jan 28, 2026
@Quetzacoalt91 Quetzacoalt91 added the bug Type: Bug fix label Jan 28, 2026
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Jan 28, 2026
@nesrineabdmouleh
Copy link
Contributor

Thank you @Quetzacoalt91, for the quick fix!
Could you please rebase your PR?

@Quetzacoalt91 Quetzacoalt91 force-pushed the fix-uninstall-on-old-ps-versions branch from c66e669 to bb0f195 Compare January 29, 2026 09:51
@sonarqubecloud
Copy link

@nesrineabdmouleh
Copy link
Contributor

Thank you @Quetzacoalt91 !

The uninstalling of the module on PS 1.7.2.1 works fine ✔️
https://www.awesomescreenshot.com/video/48872252?key=6f2670373259c4200d0d4b76c9cbe03c

@Quetzacoalt91 Quetzacoalt91 added QA ✔️ Status: Check done, Code approved and removed waiting for QA labels Jan 29, 2026
@Quetzacoalt91 Quetzacoalt91 merged commit 65ea12c into PrestaShop:dev Jan 29, 2026
58 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Merged in PR Dashboard Jan 29, 2026
@ps-jarvis
Copy link
Collaborator

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

@Quetzacoalt91 Quetzacoalt91 deleted the fix-uninstall-on-old-ps-versions branch January 29, 2026 11:44
@Quetzacoalt91 Quetzacoalt91 added this to the 7.6.0 milestone Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type: Bug fix QA ✔️ Status: Check done, Code approved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants