Update copy button to add text#1627
Merged
ga-devfront merged 4 commits intoPrestaShop:devfrom Feb 3, 2026
Merged
Conversation
Contributor
ga-devfront
commented
Jan 30, 2026
ga-devfront
commented
| Questions | Answers |
|---|---|
| Description? | Update copy button inside error modal to match new mockups. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Internal ticket |
| Sponsor company | @PrestaShopCorp |
| How to test? | Test new button styles |
Quetzacoalt91
previously approved these changes
Jan 30, 2026
tblivet
requested changes
Jan 30, 2026
Contributor
tblivet
left a comment
tblivet
left a comment
There was a problem hiding this comment.
@ga-devfront Looks good, just a few adjustments. I’ll let you test it, but with the suggestions it should be OK.
Contributor
There was a problem hiding this comment.
Suggested change
| top: 0.625rem; |
Comment on lines
+23
to
+24
| <span class="copy"><i class="material-icons">content_copy</i> {{ 'Copy'|trans({}) }}</span> | ||
| <span class="copied"><i class="material-icons">check</i> {{ 'Copied!'|trans({}) }}</span> |
Contributor
There was a problem hiding this comment.
Suggested change
| <span class="copy"><i class="material-icons">content_copy</i> {{ 'Copy'|trans({}) }}</span> | |
| <span class="copied"><i class="material-icons">check</i> {{ 'Copied!'|trans({}) }}</span> | |
| <span class="copy"><i class="wrapper-copy__button-icon material-icons">content_copy</i> {{ 'Copy'|trans({}) }}</span> | |
| <span class="copied"><i class="wrapper-copy__button-icon material-icons">check</i> {{ 'Copied!'|trans({}) }}</span> |
|
AureRita
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Hi @ga-devfront
Thank you for your PR, I tested it and it seems to works as you can see :
Capture.video.du.2026-02-02.15-56-43.mp4
Capture.video.du.2026-02-02.15-50-47.mp4
Capture.video.du.2026-02-02.15-44-35.mp4
Tested on :
1.7.8.8
8.2.3
9.0.0
Because the PR seems to works as expected, It's QA ✔️
Waiting for CI to put the QA Approved label
Thank you
ga-devfront
added
QA ✔️
github-project-automation
bot
moved this from Ready for review
to Merged
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.