Test rigorously for URLs while allowing relative URLs.

[lmeyer1]

Questions	Answers
Description?	"Test rigorously for URLs while allowing relative URLs. Symfony 3.4 has not the option relativeProtocol as newer version have. I use therefore directly a regex.
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes PrestaShop/PrestaShop#25299
How to test?	See steps to reproduce in issue PrestaShop/PrestaShop#25299

[Progi1984]

@PierreRambaud I approve. With this, the module is compatible with a bigger range of modules.

[PierreRambaud]

Few comments

[lmeyer1]

@Progi1984
About Waiting for Author tag: As far as I understand, I'm done. I've fixed what @PierreRambaud asked for.

[khouloudbelguith]

Hi @lmeyer1, @matks,

Yes, I was able to reproduce the issue with dev branch.
I created a new issue: PrestaShop/PrestaShop#28292

But this PR, I think, is blocked by this issue.
Ping @matks what do you think?

Thanks!

[jf-viguier]

Could you please reopen the PR ? It could then be tested by QA.

[ghost]

Hello @jf-viguier @khouloudbelguith && @lmeyer1

Pull Request reopen

[jf-viguier]

Thanks @okom3pom, curiously, this PR is tagged in the next version here : 5.0.5

[lmeyer1]

This PR has a Waiting for author label. What am I supposed to do ? @khouloudbelguith

[matks]

This PR has a Waiting for author label. What am I supposed to do ? @khouloudbelguith

This ping was the right thing to do 😄

[khouloudbelguith]

Hello,

I think we need to add the Blocked label since this PR cannot be tested because of this issue PrestaShop/PrestaShop#28292
I still reproduce the same bug with PS1.7.8.7 and the dev branch of the module ps_linklist.

Thanks!

[lmeyer1]

@khouloudbelguith This PR should be unblocked and PrestaShop/PrestaShop#28292 should be closed. It seems the latter has been fixed here: 0011b28

[hibatallahAouadni]

Hello @lmeyer1

Thanks for your PR 🚀
The issue of custom link url validation has been fixed with this PR 👏
But I found another issue, see the attached screen record below:

issue_25299.webm

When I tried to add a custom URL while my domain is composed (ex: prestashop/prestashop800/) the linklist module will use only the first part of the URL (ex:prestashop).
So, is this issue should be fixed in this PR or it's out of scope this PR?
Waiting for your feedback.

Thanks!

[lmeyer1]

@hibatallahAouadni
The scope of the PR was limited to allow relative URLs.
I'm aware, that relative URLs won't work in a multishop context, if there is a Virtual URI part that differs from one shop to the other.
If we have a Physical URI part in the shop URLs, IMHO, it is up to the user, to add this part in the field URL. for your case, include prestashop800/ in the relative URL.

Without this PR, the custom URL part of this module is not usable in a multishop context. Now it is, with the exception when the participating shop do not all share the same Virtual URI (by default /)

hiba took over

[kpodemski]

Thanks @lmeyer1

Sorry for the late response, it was still marked as "Waiting for author" :-(