Skip to content

Fix deprecations#165

Merged
FabienPapet merged 6 commits intoPrestaShop:devfrom
Progi1984:fixDeprecations
Feb 22, 2023
Merged

Fix deprecations#165
FabienPapet merged 6 commits intoPrestaShop:devfrom
Progi1984:fixDeprecations

Conversation

@Progi1984
Copy link
Member

@Progi1984 Progi1984 commented Feb 15, 2023 •
edited
Loading

Questions Answers
Description? Fix deprecations
Type? refactor
BC breaks? no
Deprecations? yes
Fixed ticket? Relative to PrestaShop/PrestaShop#24609 and PrestaShop/PrestaShop#31216
Sponsor company @PrestaShopCorp
How to test? The module works well on a PrestaShop 8.1.0.

@Progi1984 Progi1984 requested a review from a team February 15, 2023 08:15
@Progi1984 Progi1984 mentioned this pull request Feb 15, 2023
Merged
0x346e3730
0x346e3730 reviewed Feb 16, 2023
View reviewed changes
@0x346e3730 0x346e3730 mentioned this pull request Feb 16, 2023
Merged
0x346e3730
0x346e3730 previously approved these changes Feb 16, 2023
View reviewed changes
Hlavtox
Hlavtox previously approved these changes Feb 16, 2023
View reviewed changes
@Hlavtox Hlavtox added this to the 5.0.6 milestone Feb 16, 2023
nicosomb
nicosomb previously approved these changes Feb 16, 2023
View reviewed changes
@florine2623 florine2623 self-assigned this Feb 17, 2023
florine2623
florine2623 reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

Tested on 8.1.0 with PHP 8.1.

Upgrade to v5.1.0 OK, But when trying to configure the module, we get an error 500 :

Screenshot 2023-02-17 at 15 47 59

Too few arguments to function PrestaShopBundle\Form\Admin\Type\TranslatableType::__construct(), 0 passed in /Users/fHea/Desktop/prestashop_8.1.0-beta.1/vendor/symfony/symfony/src/Symfony/Component/Form/FormRegistry.php on line 89 and exactly 7 expected

Screenshot 2023-02-17 at 15 48 57

Could you check ?
Thanks!

@florine2623 florine2623 added Waiting for author Waiting for author feedback and removed Waiting for QA labels Feb 17, 2023
@florine2623 florine2623 removed their assignment Feb 17, 2023
@Progi1984 Progi1984 dismissed stale reviews from nicosomb, Hlavtox, and 0x346e3730 via 501a1c0 February 20, 2023 08:38
@Progi1984 Progi1984 removed the Waiting for author Waiting for author feedback label Feb 20, 2023
@Progi1984
Copy link
Member Author

Progi1984 commented Feb 20, 2023

@florine2623 Thanks for your feedback

@nicosomb & @Hlavtox I have fixed the error in 501a1c0.

Hlavtox
Hlavtox previously approved these changes Feb 20, 2023
View reviewed changes
nicosomb
nicosomb previously approved these changes Feb 20, 2023
View reviewed changes
@MhiriFaten MhiriFaten self-assigned this Feb 21, 2023
MhiriFaten
MhiriFaten previously approved these changes Feb 21, 2023
View reviewed changes
Copy link

@MhiriFaten MhiriFaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Progi1984 ,

LGTM, it is QA approved ✔️

Many thanks!

@MhiriFaten MhiriFaten added QA ✔️ Status: Check done, Code approved and removed Waiting for QA labels Feb 21, 2023
kpodemski
kpodemski requested changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking because of the discussion around modules versioning.

@Progi1984
Copy link
Member Author

Progi1984 commented Feb 21, 2023

Blocking because of the discussion around modules versioning.

@kpodemski Could you please give the Github Discussion / Github Issue ? Or is it a private discussion ?

@Progi1984 Progi1984 added the Blocked Status: The issue is blocked by another task label Feb 21, 2023
@kpodemski
Copy link
Contributor

kpodemski commented Feb 21, 2023 •
edited
Loading

@Progi1984 it's a private discussion with other maintainers, there will be an ADR

@Progi1984
Copy link
Member Author

Progi1984 commented Feb 21, 2023

@Progi1984 it's a private discussion with other maintainers, there will be an ADR

Perfect. Thanks

@Progi1984
Copy link
Member Author

Progi1984 commented Feb 21, 2023

Blocked by PrestaShop/ADR#32

@Progi1984 Progi1984 dismissed stale reviews from MhiriFaten, nicosomb, and Hlavtox via 39ba9a0 February 22, 2023 13:26
@kpodemski
Copy link
Contributor

kpodemski commented Feb 22, 2023

Module ready to be released.

@Hlavtox
Copy link
Contributor

Hlavtox commented Feb 22, 2023

After this is merged no?

@FabienPapet
Copy link
Member

FabienPapet commented Feb 22, 2023

Yes @Hlavtox

@Hlavtox Hlavtox removed the Blocked Status: The issue is blocked by another task label Feb 22, 2023
@FabienPapet FabienPapet merged commit f632297 into PrestaShop:dev Feb 22, 2023
@Progi1984 Progi1984 deleted the fixDeprecations branch February 22, 2023 13:33
@lartist lartist mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@florine2623 florine2623 florine2623 left review comments

@FabienPapet FabienPapet FabienPapet approved these changes

@kpodemski kpodemski kpodemski approved these changes

@nicosomb nicosomb nicosomb left review comments

@Hlavtox Hlavtox Hlavtox left review comments

@0x346e3730 0x346e3730 0x346e3730 left review comments

+1 more reviewer

@MhiriFaten MhiriFaten MhiriFaten left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@MhiriFaten MhiriFaten

Labels

QA ✔️ Status: Check done, Code approved

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@Progi1984 @kpodemski @Hlavtox @FabienPapet @nicosomb @florine2623 @0x346e3730 @MhiriFaten