Merged
Conversation
Contributor
jolelievre
commented
Sep 6, 2024
jolelievre
commented
| Questions | Answers |
|---|---|
| Description? | Release 7.0.0 |
| Type? | refacto |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed ticket? | ~ |
| How to test? | ~ |
Make module compliant with PSV9
nicosomb
previously requested changes
Sep 6, 2024
Contributor
nicosomb
left a comment
nicosomb
left a comment
There was a problem hiding this comment.
wait monday before releasing this PR
tleon
approved these changes
Sep 6, 2024
jolelievre
added
QA ✔️
jolelievre
dismissed
nicosomb’s stale review
Thanks for the blockage, monday it is!
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.