Skip to content

test#49

Closed
LeoGrin wants to merge 5 commits intomainfrom
test
Closed

test#49
LeoGrin wants to merge 5 commits intomainfrom
test

Conversation

@LeoGrin
Copy link
Contributor

@LeoGrin LeoGrin commented Dec 6, 2024

Change Description

Try to be precise. You can additionally add comments to your PR, this might help the reviewer a lot.

If you used new dependencies: Did you add them to requirements.txt?

Who did you ping on Mattermost to review your PR? Please ping that person again whenever you are ready for another review.

Breaking changes

If you made any breaking changes, please update the version number.
Breaking changes are totally fine, we just need to make sure to keep the users informed and the server in sync.

Does this PR break the API? If so, what is the corresponding server commit?

Does this PR break the user interface? If so, why?


Please do not mark comments/conversations as resolved unless you are the assigned reviewer. This helps maintain clarity during the review process.

@LeoGrin
Copy link
Contributor Author

LeoGrin commented Dec 6, 2024

This is a toy pr (no change) to check that the CI breaking is not due to some changes in another PR. Would some of you have an idea of what's causing the error? @SamuelGabriel @davidotte maybe? Otherwise I'll investigate. Maybe something changed in the CI or something? I get no error when running the tests locally.

@davidotte
Copy link
Collaborator

No idea, I would also need to investigate 🤔

@noahho
Copy link
Collaborator

noahho commented Dec 11, 2024

Could it be the mock server tabpfn-server-wjedmz7r5a-ez.a.run.app has changed? The restx library seems to be stable for a while

@noahho
Copy link
Collaborator

noahho commented Dec 11, 2024

Locally things are running, but not on the server

@LeoGrin
Copy link
Contributor Author

LeoGrin commented Dec 11, 2024

Okay it seems to be due to version differences in the httpx package. Downgrading to httpx-0.27.2 makes it work locally while the latest version (0.28.1) also fails locally. 0.28.1 came out on December 6th, and we only specify a minimum version in the requirement.txt file so the CI uses the latest version.

@LeoGrin
Copy link
Contributor Author

LeoGrin commented Dec 11, 2024

#51 should fix this

@LeoGrin LeoGrin closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants