Skip to content

2339 adds partial weight util#2351

Merged
wyli merged 13 commits intoProject-MONAI:devfrom
wyli:2339-partial-model-util
Jun 16, 2021
Merged

2339 adds partial weight util#2351
wyli merged 13 commits intoProject-MONAI:devfrom
wyli:2339-partial-model-util

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Jun 9, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #2339

Description

adds a weight loading util

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the 2339-partial-model-util branch 2 times, most recently from cd61f13 to c3fc81f Compare June 10, 2021 13:13
@wyli wyli marked this pull request as ready for review June 15, 2021 15:30
@wyli wyli requested review from Nic-Ma, ericspod and rijobro June 15, 2021 15:30
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jun 15, 2021

Thanks for this new feature, it can be useful for transfer learning.
I will try to review it tomorrow daytime.

Thanks.

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick PR, I put several minor comments inline.
Others look good to me.

Thanks.

@wyli wyli force-pushed the 2339-partial-model-util branch from 2f8df13 to b645814 Compare June 16, 2021 08:54
wyli added 10 commits June 16, 2021 10:19
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 2339-partial-model-util branch from b645814 to 7e6efa5 Compare June 16, 2021 09:19
@wyli wyli requested review from Nic-Ma and rijobro June 16, 2021 09:51
Copy link
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help also update the test file name to test_copy_model_state.py?
Others look good to me.

Thanks.

wyli added 2 commits June 16, 2021 11:11
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 2339-partial-model-util branch from b62534a to 5e545d1 Compare June 16, 2021 11:00
@wyli wyli enabled auto-merge (squash) June 16, 2021 14:05
@wyli wyli merged commit b151b8e into Project-MONAI:dev Jun 16, 2021
@wyli wyli deleted the 2339-partial-model-util branch June 16, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Utilities for partially loading weights from a state_dict

3 participants