Skip to content

Fix jupyter util issue#2361

Merged
Nic-Ma merged 4 commits intoProject-MONAI:devfrom
Nic-Ma:fix-jupyter-util
Jun 11, 2021
Merged

Fix jupyter util issue#2361
Nic-Ma merged 4 commits intoProject-MONAI:devfrom
Nic-Ma:fix-jupyter-util

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jun 11, 2021

Fixes Project-MONAI/tutorials#230

Description

This PR enhanced the jupyter util to fix tutorial issue.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested a review from ericspod June 11, 2021 16:47
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 11, 2021

Hi @ericspod ,

I didn't reproduce the tutorial issue: Project-MONAI/tutorials#230, but seems related to this line, so I added the check in this PR.

Thanks.

@Nic-Ma Nic-Ma requested review from rijobro and wyli June 11, 2021 16:49
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 11, 2021

/black

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Nic-Ma Nic-Ma enabled auto-merge (squash) June 11, 2021 17:17
@Nic-Ma Nic-Ma merged commit c1b5028 into Project-MONAI:dev Jun 11, 2021
@Nic-Ma Nic-Ma deleted the fix-jupyter-util branch July 2, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly test error: modules/jupyter_utils.ipynb

2 participants