2380 fix inverse bug of CenterScaleCropd transform#2383
Merged
Nic-Ma merged 5 commits intoProject-MONAI:devfrom Jun 17, 2021
Merged
2380 fix inverse bug of CenterScaleCropd transform#2383Nic-Ma merged 5 commits intoProject-MONAI:devfrom
Nic-Ma merged 5 commits intoProject-MONAI:devfrom
Conversation
merge master
merge master
merge master
Nic-Ma
changed the title
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
changed the title
Contributor
Author
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
yiheng-wang-nv
approved these changes
Jun 17, 2021
wyli
reviewed
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2380 .
Description
The
CenterScaleCropdinherited fromCenterSpatialCropdbefore and used theinversefunction of super class.Below PR changed the super class and caused issue #2380 :
a49a63c#diff-89a2deab37fbf5ef93565148b6137404dea3e6aea900aa0a5e027a98007e76b2L406
This PR fixed this issue and added unit tests for
CenterScaleCropd.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.