2415 - add json config model support for mmar loading#2416
Merged
wyli merged 2 commits intoProject-MONAI:devfrom Jun 23, 2021
Merged
2415 - add json config model support for mmar loading#2416wyli merged 2 commits intoProject-MONAI:devfrom
wyli merged 2 commits intoProject-MONAI:devfrom
Conversation
wyli
changed the title
wyli
force-pushed
the
fixes-path-mmar
branch
2 times, most recently
from
bfea4a5 to
6605c55
Compare
Nic-Ma
reviewed
Jun 23, 2021
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the enhancement, I put some minor comments.
Others look good to me.
Thanks.
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Nic-Ma
approved these changes
Jun 23, 2021
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick update.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #2415
Description
adds support of model config from json
Status
Ready
Types of changes
./runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.