2290 Add support to update data in Datasets#2436
Conversation
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
wyli
left a comment
There was a problem hiding this comment.
I think the new method could be set_data instead of update_data? not sure about the overall stability in the multiprocess loading because there will be concurrent read and write for the cache. maybe the PersistentDataset is ok but how about the other datasets?
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
Hi @wyli , Thanks for your review and suggestions. Thanks in advance. |
|
Hi @wyli , BTW, I already added the doc-string in Thanks. |
Signed-off-by: Nic Ma <nma@nvidia.com>
wyli
left a comment
There was a problem hiding this comment.
thanks, just need to change the docstring update_data() to set_data()
Signed-off-by: Nic Ma <nma@nvidia.com>
Fixes #2290 .
Description
This PR added support to update data after several epochs in Datasets.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.