Skip to content

2453 Enhance ToTensor transform to support data with no dim#2454

Merged
wyli merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:2453-fix-totensor
Jun 26, 2021
Merged

2453 Enhance ToTensor transform to support data with no dim#2454
wyli merged 7 commits intoProject-MONAI:devfrom
Nic-Ma:2453-fix-totensor

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jun 25, 2021 •
edited
Loading

Fixes #2453 .

Description

This PR enhanced the ToTensor transform to support data without dimension, also added unit tests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli and removed request for wyli June 25, 2021 16:32
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 25, 2021

/black

wyli
wyli reviewed Jun 25, 2021
View reviewed changes
@Nic-Ma
[DLMED] update according to comments
2726f91 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jun 25, 2021

/black

@Nic-Ma Nic-Ma requested a review from wyli June 26, 2021 09:23
wyli
wyli approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wyli wyli merged commit 9f9b63a into Project-MONAI:dev Jun 26, 2021
wyli pushed a commit to holgerroth/MONAI that referenced this pull request Jun 28, 2021
@Nic-Ma @wyli
2453 Enhance ToTensor transform to support data with no dim (Project-…
ee0a368 
…MONAI#2454)

* [DLMED] enhance ToTensor

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@Nic-Ma Nic-Ma deleted the 2453-fix-totensor branch July 2, 2021 23:36
@Nic-Ma Nic-Ma mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ToTensor() transform adds unexpected dim

2 participants

@Nic-Ma @wyli