4060 Add PatchIter and PatchIterd transform #4061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Nic Ma <[email protected]>
…into 4060-add-patchiterd Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
changed the title
Contributor
Author
|
/black |
Contributor
Author
|
/build |
wyli
reviewed
Apr 5, 2022
wyli
reviewed
Apr 5, 2022
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
ericspod
reviewed
Apr 5, 2022
wyli
approved these changes
Apr 5, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
thanks this looks ok although I think 1. PatchIter's docstring change and docs/source/data.rst changes are unnecessary, and 2. it might be useful to include the original image size and start_pos in each returned patch dictionary, so that it's possible to (partially) reconstruct the original image from the patches.
Signed-off-by: Nic Ma <[email protected]>
Nic-Ma
force-pushed
the
4060-add-patchiterd
branch
from
aa24eb7 to
769a4c3
Compare
Signed-off-by: Nic Ma <[email protected]>
Signed-off-by: Nic Ma <[email protected]>
Contributor
Author
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4060 .
Description
This PR added
PatchIterandPatchIterdtransform according to user's feedback.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.